Custom job durations working.

asimy · Sep 24, 2011 · 84fa937 · 84fa937
1 parent f44d070
commit 84fa937
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/resque/plugins/job_stats/duration.rb b/lib/resque/plugins/job_stats/duration.rb
@@ -10,7 +10,7 @@ def reset_job_durations
 
         # Returns the number of jobs failed
         def job_durations
-          Resque.redis.lrange(jobs_duration_key,0,job_durations_to_track).map(&:to_f)
+          Resque.redis.lrange(jobs_duration_key,0,durations_recorded - 1).map(&:to_f)
         end
 
         # Returns the key used for tracking job durations
@@ -25,11 +25,11 @@ def around_perform_job_stats_duration(*payload)
           duration = Time.now - start
 
           Resque.redis.lpush(jobs_duration_key, duration)
-          Resque.redis.ltrim(jobs_duration_key, 0, job_durations_to_track)
+          Resque.redis.ltrim(jobs_duration_key, 0, durations_recorded)
         end
 
-        def job_durations_to_track
-          100
+        def durations_recorded
+          @durations_recorded || 100
         end
 
         def job_rolling_avg

diff --git a/test/test_job_stats.rb b/test/test_job_stats.rb
@@ -83,12 +83,12 @@ def test_duration
   def test_custom_duration
     CustomDurJob.reset_job_durations
 
-    2.times do |i|
+    2.times do
       Resque.enqueue(CustomDurJob,1.0)
       @worker.work(0)
     end
 
-    5.times do |i|
+    5.times do
       Resque.enqueue(CustomDurJob,0.1)
       @worker.work(0)
     end