Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible React State update bug #43

Closed
ArenaGrenade opened this issue Jun 11, 2021 · 2 comments
Closed

Possible React State update bug #43

ArenaGrenade opened this issue Jun 11, 2021 · 2 comments

Comments

@ArenaGrenade
Copy link

Steps to produce the state update bug:

  1. Mark 2-3 questions (lets say 0, 1, 2) as solved.
  2. Press the "mark all" button once. (Here state should update such that the elements / problems are re-sorted)
    The above step gave a part of the bug
  3. Press the "mark all" button once. Now all problems should be marked done. Now press "mark all" button again.
  4. Press the "mark all" button again. (Here the state should update so that either all are truly unmarked (I will get back to this) or we need to have all of them removed.

At first sight after the above step, it seems that all are unmarked, but now go back and mark one of the initially marked questions, all the questions that were marked initially immediately turns to be marked.

I hope I was clear with the description. If not please feel free to continue in this thread.

@AsishRaju
Copy link
Owner

@ArenaGrenade thanks for bringing this up, select all checkbox handling was intentionally not implemented. Didn't find any valid reason to handle select all but if you have a user story regarding this do follow up.

The select all checkbox shouldn't have made it to production in the first place if it didn't have any logic in the first place to handle it. Apologies for that 😅, removed it on the new build.

@ArenaGrenade
Copy link
Author

Amazing!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants