Detect useless property annotation

ptscs/ruleset.xml

@@ -194,6 +194,9 @@
     <rule ref="SlevomatCodingStandard.Functions.UnusedInheritedVariablePassedToClosure" />
     <rule ref="SlevomatCodingStandard.Commenting.DisallowOneLinePropertyDocComment" />
 
+    <!-- Useless typehint -->
+    <rule ref="SlevomatCodingStandard.TypeHints.PropertyTypeHint.UselessAnnotation" />
+
 
     <!--++++++++++++++++++++++++++++++++++++
     Code analysis

tests/Sniffs/Slevomat/TypeHints/PropertyTypeHintTest.php

@@ -0,0 +1,25 @@
+<?php declare(strict_types=1);
+
+namespace Ptscs\Tests\Sniffs\Slevomat\TypeHints;
+
+use Iterator;
+use Ptscs\Tests\SniffTestCase;
+use Ptscs\Tests\Utils\ErrorData;
+
+final class PropertyTypeHintTest extends SniffTestCase
+{
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $this->appendExclude('Squiz.Classes.ClassFileName.NoMatch');
+    }
+
+    public static function provideTestData(): Iterator
+    {
+        yield [
+          [
+            new ErrorData(10, 'SlevomatCodingStandard.TypeHints.PropertyTypeHint.UselessAnnotation'),
+          ],
+        ];
+    }
+}

tests/Sniffs/Slevomat/TypeHints/UselessDocblockTest.php

@@ -0,0 +1,20 @@
+<?php declare(strict_types=1);
+
+namespace Ptscs\Tests\Sniffs\Slevomat\TypeHints;
+
+use Iterator;
+use Ptscs\Tests\SniffTestCase;
+
+final class UselessDocblockTest extends SniffTestCase
+{
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $this->appendExclude('Squiz.Classes.ClassFileName.NoMatch');
+    }
+
+    public static function provideTestData(): Iterator
+    {
+        yield [];
+    }
+}

tests/Sniffs/Slevomat/TypeHints/_data/PropertyTypeHint.php.fixed

@@ -0,0 +1,48 @@
+<?php declare(strict_types=1);
+
+namespace App;
+
+use Symfony\Component\Validator\Constraints as Assert;
+
+final class Foobar
+{
+    private string $useless;
+
+    /**
+     * @Assert\NotBlank
+     */
+    private $missing;
+
+    /**
+     * Description
+     *
+     */
+    private string $value1;
+
+    private ?int $value2 = null;
+
+    private string|int|float $value3;
+
+    /**
+     * @var string[]
+     */
+    private array $value4;
+
+    /**
+     * @var string The hashed password
+     */
+    private string $password;
+
+    private $inferMissing;
+
+    /**
+     * @var int
+     */
+    private $inferUseless;
+
+    public function __construct(string $inferMissing, int $inferUseless)
+    {
+        $this->inferMissing = $inferMissing;
+        $this->inferUseless = $inferUseless;
+    }
+}

tests/Sniffs/Slevomat/TypeHints/_data/PropertyTypeHint.php.inc

@@ -0,0 +1,51 @@
+<?php declare(strict_types=1);
+
+namespace App;
+
+use Symfony\Component\Validator\Constraints as Assert;
+
+final class Foobar
+{
+    /**
+     * @var string
+     */
+    private string $useless;
+
+    /**
+     * @Assert\NotBlank
+     */
+    private $missing;
+
+    /**
+     * Description
+     *
+     */
+    private string $value1;
+
+    private ?int $value2 = null;
+
+    private string|int|float $value3;
+
+    /**
+     * @var string[]
+     */
+    private array $value4;
+
+    /**
+     * @var string The hashed password
+     */
+    private string $password;
+
+    private $inferMissing;
+
+    /**
+     * @var int
+     */
+    private $inferUseless;
+
+    public function __construct(string $inferMissing, int $inferUseless)
+    {
+        $this->inferMissing = $inferMissing;
+        $this->inferUseless = $inferUseless;
+    }
+}

tests/Sniffs/Slevomat/TypeHints/_data/UselessDocblock.php.fixed

@@ -0,0 +1,28 @@
+<?php declare(strict_types=1);
+
+namespace App;
+
+final class Foobar
+{
+    /**
+     * @var string
+     */
+    private $value;
+
+    /**
+     * Class constructor.
+     * @param string $value
+     */
+    public function __construct(string $value)
+    {
+        $this->value = $value;
+    }
+
+    /**
+     * @return string
+     */
+    public function getValue(): string
+    {
+        return $this->value;
+    }
+}

tests/Sniffs/Slevomat/TypeHints/_data/UselessDocblock.php.inc

@@ -0,0 +1,28 @@
+<?php declare(strict_types=1);
+
+namespace App;
+
+final class Foobar
+{
+    /**
+     * @var string
+     */
+    private $value;
+
+    /**
+     * Class constructor.
+     * @param string $value
+     */
+    public function __construct(string $value)
+    {
+        $this->value = $value;
+    }
+
+    /**
+     * @return string
+     */
+    public function getValue(): string
+    {
+        return $this->value;
+    }
+}