-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix removing forced parquet and clear images from piperun #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srggrs
changed the title
Fix high priority tags (WIP)
Fix removing forced parquet and clear images from piperun
Aug 25, 2020
Be good to get #283 merged so I can test this with forced fits a bit smoother. |
@ajstewart approved #283 so merge and I'll resolve the conflicts here if any |
* master: Replace upload with function Fix source query Fixed upload indent removed flux_percentile field Update pipeline/models.py fix grammar error change to simple test case change mapping to srcs_df id column dict removed fields flux gain and its errors fix datatables for multi tables, add related table, minor fixes removed comment removed not used parameter removed unnecessary file fix upload function to use refactor bulk upload, minor changes remove dropping unque pairs, add dropping same related, small changes change to symmetrical False, add unique constraint fix related creation and upload, minor fixes added model utils with bulk update model function locking ipython version to avoid inf loops in dask when debug add m2m related source through, remove un-used fields # Conflicts: # pipeline/pipeline/forced_extraction.py
ajstewart
previously approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now fixes #210 as well 👍.
Co-authored-by: Adam Stewart <ajstewart@users.noreply.github.com>
ajstewart
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #211 and #210
@ajstewart can u test this to check the fixes are solved?