Suppress astropy warnings #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srggrs
reviewed
Sep 4, 2020
There was a problem hiding this comment.
Are you sure you need that in all of the 3 files? the code call the forced phot and new sources functions from the process_pipeline method.
Also would be good if you could customize this as a settings in the run config file. But maybe is not worth the effort for the time being...
|
Yes sorry this was a lazy implementation I'll change it. The thought of making it an option crossed my mind as well, should it be tied to debug mode do you think or have it's own option? |
|
I've moved it to one place and added a user config option. |
srggrs
approved these changes
Sep 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppresses the Astropy warnings.
Fixes #279.