Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unique to image name, remove timestamp from image folder #322

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

srggrs
Copy link
Contributor

@srggrs srggrs commented Sep 8, 2020

Fix #313. This is necessary for forced phot bug fix #325 as we "groupby" (not really in the bug fix, but we use to before, in any case we assume in the code that image names are unique) image name, and run the forced extraction on those image files, so you would expect that the image name would be unique.

@github-actions github-actions bot added this to In progress in Pipeline Backlog Sep 8, 2020
@srggrs srggrs marked this pull request as ready for review September 8, 2020 06:34
Pipeline Backlog automation moved this from In progress to Reviewer approved Sep 9, 2020
@srggrs
Copy link
Contributor Author

srggrs commented Sep 10, 2020

@marxide can I merge this?

@srggrs srggrs merged commit bb279f3 into master Sep 10, 2020
Pipeline Backlog automation moved this from Reviewer approved to Done Sep 10, 2020
@srggrs srggrs deleted the issue-313-unique-image-name branch September 10, 2020 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Proposal change image field name to be unique
3 participants