Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed aladin init for all pages #344

Merged
merged 1 commit into from
Sep 23, 2020
Merged

fixed aladin init for all pages #344

merged 1 commit into from
Sep 23, 2020

Conversation

marxide
Copy link
Contributor

@marxide marxide commented Sep 22, 2020

Refactored the aladin config into a function and decoupled the initialization.
Fixes #343.

Refactored the aladin config into a function and decoupled the initialization.
Fixes #343.
@marxide marxide self-assigned this Sep 22, 2020
@github-actions github-actions bot added this to In progress in Pipeline Backlog Sep 22, 2020
@marxide marxide added bug Something isn't working UI User Interface labels Sep 22, 2020
@github-actions github-actions bot added this to In progress in Nimbus Production Sep 22, 2020
Copy link
Contributor

@srggrs srggrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THank you for that! Good refactoring!

Pipeline Backlog automation moved this from In progress to Reviewer approved Sep 23, 2020
Nimbus Production automation moved this from In progress to Reviewer approved Sep 23, 2020
@srggrs
Copy link
Contributor

srggrs commented Sep 23, 2020

I think once this is merged I can start creating the first release.

@marxide marxide merged commit ad85eaf into master Sep 23, 2020
Pipeline Backlog automation moved this from Reviewer approved to Done Sep 23, 2020
Nimbus Production automation moved this from Reviewer approved to Done Sep 23, 2020
@marxide marxide deleted the issue-343-aladin branch September 23, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI User Interface
Projects
Development

Successfully merging this pull request may close these issues.

Aladin not loading on measurement and image detail pages
3 participants