-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check all options are valid and present in validate_cfg #373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you want to enforce even options that would be optional if the method is not selected: for example if force extraction is turned off, we do not need the MONITOR_*
options in the config.
I think this is fine, as long as we all on the same page @ajstewart @marxide
Yes that was on purpose, as the template should be used when creating jobs all options should be present in any case, and some parameters are still checked in the code when perhaps the user didn't think about the option. We can make this clear in documentation. |
Are you happy with this validation method @marxide? |
At the top of the config validation I've changed it such that the first thing that takes place is a check for:
I think it's good to enforce this as then the user shouldn't have any surprise settings that they weren't aware of if they somehow created their own config file.
This also avoids the issue in #365 where any not defined options needed later in the process are caught at the beginning and hence doesn't waste any time.
As this full check is now in place I have removed a few checks that were there checking for individual settings.
Fixes #365.