Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rms value calculation in non-cluster forced extractions #402

Merged
merged 2 commits into from
Nov 4, 2020

Conversation

ajstewart
Copy link
Contributor

I have brought over the necessary changes from the forced_phot code to fix #400.

I only changed what was necessary with the intention that this will soon be moved to be a dependancy (askap-vast/forced_phot#4). So this will fix #400 for now in case we don't get around to this soon.

Fixes #400.

@ajstewart ajstewart added the bug Something isn't working label Oct 26, 2020
@ajstewart ajstewart self-assigned this Oct 26, 2020
@github-actions github-actions bot added this to In progress in Pipeline Backlog Oct 26, 2020
@github-actions github-actions bot added this to In progress in Nimbus Production Oct 26, 2020
srggrs
srggrs previously approved these changes Oct 28, 2020
Copy link
Contributor

@srggrs srggrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!

Pipeline Backlog automation moved this from In progress to Reviewer approved Oct 28, 2020
Nimbus Production automation moved this from In progress to Reviewer approved Oct 28, 2020
Pipeline Backlog automation moved this from Reviewer approved to Review in progress Nov 4, 2020
Nimbus Production automation moved this from Reviewer approved to Review in progress Nov 4, 2020
@ajstewart ajstewart merged commit 6678a59 into master Nov 4, 2020
Pipeline Backlog automation moved this from Review in progress to Done Nov 4, 2020
Nimbus Production automation moved this from Review in progress to Done Nov 4, 2020
@ajstewart ajstewart deleted the issue-400-fix-forced-phot-rms branch November 4, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Wrong local_rms estimation for forced fitted measurements
2 participants