use forced_phot dependency instead of copied code

[marxide]

Replace the copied version of forced_phot with a pip depdendency to the forced_phot repo.
Closes askap-vast/forced_phot#4.

[ajstewart]

The pipeline changes look good, but on the forced photometry side I agree with the steps that @srggrs said:

• move the code out of __init__.py and into forced_phot.py
• make a tag and a release
• set up the git submodule in Vast pipeline with reference to a specific tag

The last one has been done, it would be good to do the first two as well.

done

[srggrs]

is that repo public?

[ajstewart]

I guess while this repo is also still private that one also doesn't need to be. We should make sure both become public when the pipeline is made public however, maybe create a specific issue so we don't forget.

[ajstewart]

Looks good to me, can you confirm that you've been able to test successfully, including seeing that the out of range filtering working.

I've opened #414 to address @srggrs point about the repos being public.

[marxide]

Looks good to me, can you confirm that you've been able to test successfully, including seeing that the out of range filtering working.

I've opened #414 to address @srggrs point about the repos being public.

I don't think the tests I run cover that specific case. I see this when I run both the master version and this version with debug logging on:

forced_phot DEBUG Removing 0 sources that are outside of the image range

The forced_measurement parquet files are also identical, except for the component names that are based on a timestamp.

[ajstewart]

I've tested this myself and it is working ok. Good to go.