Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated npm deps to fix security vulnerabilities #411

Merged
merged 4 commits into from
Nov 23, 2020
Merged

Conversation

marxide
Copy link
Contributor

@marxide marxide commented Nov 5, 2020

Bumped various npm package versions to address some dependabot security alerts.

@github-actions github-actions bot added this to In progress in Pipeline Backlog Nov 5, 2020
@marxide marxide self-assigned this Nov 5, 2020
@marxide marxide added the dependencies Pull requests that update a dependency file label Nov 5, 2020
@marxide
Copy link
Contributor Author

marxide commented Nov 5, 2020

Please give the UI a test to make sure nothing has broken. It looked fine to me.

@srggrs srggrs mentioned this pull request Nov 9, 2020
ajstewart
ajstewart previously approved these changes Nov 16, 2020
Copy link
Contributor

@ajstewart ajstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be be fine with the UI with my local testing!

I added a small commit to the d3 celestial script as on this version suddenly the d3-celestial plot was animating to follow local zenith (when location is available in the browser). While quite cool, I have locked it to the 0,0 centre.

Pipeline Backlog automation moved this from In progress to Reviewer approved Nov 16, 2020
srggrs
srggrs previously approved these changes Nov 18, 2020
Copy link
Contributor

@srggrs srggrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good for me too!

@marxide marxide dismissed stale reviews from srggrs and ajstewart via d6dde8b November 23, 2020 20:50
Pipeline Backlog automation moved this from Reviewer approved to Review in progress Nov 23, 2020
@marxide marxide merged commit b1fa574 into master Nov 23, 2020
Pipeline Backlog automation moved this from Review in progress to Done Nov 23, 2020
@marxide marxide deleted the update-npm-deps branch November 23, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants