Added custom 404 and 500 templates #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In production, you would set those pages in the load balancer configuration file. |
Hmm ok, so does this need any changing here? What would be the instructions to implement this? |
So no extra instructions are needed in the README in order to set these up or anything? @srggrs |
I'll test how it works and add them directly to the main documentation I'm building |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added custom 404 and 500 templates, which I believe are read by default as long as they are named and placed in the templates as I've done. So I think this should just work once in production.
I managed to test it on my
debug=Trueenvironment by using this technique: https://spapas.github.io/2015/04/29/django-show-404-page/.I used the 404.html template from sb-admin-2.
Preview of the 500 page:
Fixes #290.