Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix particles and breadcrumb issues on mobile. #459

Merged
merged 2 commits into from
Jan 10, 2021

Conversation

ajstewart
Copy link
Contributor

  • Fixed canvas sizing of particles effect.
  • Changed login card width to be wider for very narrow screens.
  • Changed particles effect to 'NASA' style (I thought it looked better suited and is less intensive on the browser).
  • Fixed breadcrumb newline on mobile.

The width of the card could possibly be placed in some pixel logic in the CSS but I thought this was better for now.

Fixes #458.

Screenshots below (in the second one I have narrowed it further by opening the console which shows the card is still ok).

Screen Shot 2021-01-10 at 15 52 24

Screen Shot 2021-01-10 at 15 53 01

Screen Shot 2021-01-10 at 15 53 47

- Fixed canvas sizing of particles effect.
- Changed login card width.
- Changed particles effect to 'NASA' style.
- Fixed breadcrumb newline on mobile.
@ajstewart ajstewart added the UI User Interface label Jan 10, 2021
@ajstewart ajstewart requested a review from srggrs January 10, 2021 05:04
@ajstewart ajstewart self-assigned this Jan 10, 2021
@github-actions github-actions bot added this to In progress in Pipeline Backlog Jan 10, 2021
Copy link
Contributor

@srggrs srggrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Pipeline Backlog automation moved this from In progress to Reviewer approved Jan 10, 2021
@ajstewart ajstewart merged commit 6e1b65d into master Jan 10, 2021
Pipeline Backlog automation moved this from Reviewer approved to Done Jan 10, 2021
@ajstewart ajstewart deleted the issue458-fix-mobile-particles-breadcrumbs branch January 10, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User Interface
Projects
Development

Successfully merging this pull request may close these issues.

UI Mobile Issues - Login and Breadcrumbs
2 participants