-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added image add mode run restore command #463
Conversation
@srggrs see what you think of this. I wasn't sure if the functions should be placed somewhere else. See the original PR comment for details on how it works. |
d167d9e
to
984967d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes otherwise LGTM
Co-authored-by: Serg <34258464+srggrs@users.noreply.github.com>
Thanks, I've applied those changes. I will document this feature once #433 is in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good
#443 should be merged first.Adds a new CLI option to restore a pipeline run that has been run through add mode to the previous version as saved in the
.bak
files from add mode.I thought this at least gives an admin power to 'undo' a pipeline run that someone might have added the wrong image or if something goes wrong during add mode the job can be saved and restored without much trouble. It waits for user confirmation before proceeding with a restore.
For now I decided this option shouldn't be available through the UI, only admins via CLI, but this could be added in the future.
Fixes #435.
Example: