Expand access to TILES data

[ddobie]

Fix #320.
Fix #217.

[pep8speaks]

Hello @ddobie! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-03-04 00:36:41 UTC

[vast-bot]

Hello @ddobie! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-02-08 05:25:37 UTC

[ajstewart]

Is it worth a test to check that the stokes parameter is being understood and used correctly when it gets the files?

[ddobie]

I'm not sure what you mean by that

[ajstewart]

I'm not sure what you mean by that

Sorry, I was meaning the test that has changed in this PR, the get_files one, it isn't testing that the different stokes files are obtained correctly. I wondered if it was worth adding a parametrize on that test to also add the stokes argument (if it works like that I can't remember - or if there isn't already a stokes test that I have forgotten about).

[ajstewart]

I might be getting confused here, is there now access to stokes V tiles? And not just stokes I?

As my last comment came from this bit where the stokes has been added.

As there is also this test which may need to be sorted out:

vast-tools/tests/test_query.py

Lines 566 to 594 in e6d17b7

	def test_init_failure_stokes_v_tiles(self, mocker) -> None:
	"""
	Tests the initialisation failure of a Query object.
	Specifically when Stokes V is requested on tile images.
	Args:
	mocker: The pytest-mock mocker object.
	Returns:
	None
	"""
	with pytest.raises(vtq.QueryInitError) as excinfo:
	isdir_mocker = mocker.patch(
	'vasttools.query.os.path.isdir',
	return_value=True
	)
	test_dir = '/testing/folder'
	query = vtq.Query(
	epochs='all-vast',
	planets=['Mars'],
	base_folder=test_dir,
	stokes='v',
	use_tiles=True
	)
	assert str(excinfo.value).startswith(
	"Problems found in query settings!"
	)

[ddobie]

I'm also a tad confused, but I think/hope my latest commit has addressed what you're talking about.

You're right, there's no access to stokes V tiles yet, but I figured I might as well remove the hardcoded stokes I while I'm working on that part of the code so it's there and ready if we do decide to add it in the future.

[ajstewart]

Ok so the coded blocks for Stokes V tiles, like what that test I linked to above is checking, should remain for now?

[ajstewart]

All good if the Stokes V tiles block does need to remain.