Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for pipeline runs with no measurement pairs file #478

Merged
merged 12 commits into from
Aug 25, 2023
Merged

Conversation

ddobie
Copy link
Collaborator

@ddobie ddobie commented Aug 18, 2023

This PR adds a check for the measurement_pairs files existence and if they do not exist, disables the relevant functionality.

The testing is also updated appropriately.

@ddobie ddobie marked this pull request as ready for review August 23, 2023 08:06
@ddobie ddobie requested a review from ajstewart August 23, 2023 08:06
ajstewart
ajstewart previously approved these changes Aug 24, 2023
Copy link
Collaborator

@ajstewart ajstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good to me!

I have made a few comments that I think could tidy it a bit, up to you, but approved as it's not anything that would require another review.

vasttools/pipeline.py Outdated Show resolved Hide resolved
vasttools/pipeline.py Outdated Show resolved Hide resolved
vasttools/pipeline.py Outdated Show resolved Hide resolved
@ddobie
Copy link
Collaborator Author

ddobie commented Aug 25, 2023

Thanks! I've implemented them all

@ddobie ddobie merged commit 6418c35 into dev Aug 25, 2023
3 checks passed
@ddobie ddobie deleted the fix-iss-376 branch August 25, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants