Properly scope search results (prevent rejected questions showing)

askaway · Sep 13, 2014 · f541bac · f541bac
1 parent 9d604e1
commit f541bac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb
@@ -1,6 +1,6 @@
 class SearchController < ApplicationController
   def index
-    @questions = Question.search(params[:q]).page(params[:page])
+    @questions = policy_scope(Question).search(params[:q]).page(params[:page])
     respond_to do |format|
       format.html
       format.json{ render 'questions/index' }

diff --git a/spec/controllers/search_controller_spec.rb b/spec/controllers/search_controller_spec.rb
@@ -2,6 +2,7 @@
 
 RSpec.describe SearchController, :type => :controller do
   let(:question){ FactoryGirl.create(:question, body: "Wes Anderson biodiesel.") }
+  let(:bad_question){ FactoryGirl.create(:question, body: "What the fuck") }
   let(:answer){ FactoryGirl.create(:answer, body: "Wes Anderson biodiesel.") }
 
   describe "GET 'index'" do
@@ -22,6 +23,7 @@
       let(:query){ "Wes Anderson" }
       it{ expect(assigns(:questions)).to include(question) }
       it{ expect(assigns(:questions)).to include(answer.question) }
+      it{ expect(assigns(:questions)).not_to include(bad_question) }
     end
   end