fix: window not defined - causing build to fail #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ramit-mitra
commented
May 18, 2022
ramit-mitra
commented
- Linked to issue Build fails on Gatsby project - WebpackError: ReferenceError: window is not defined #18
✅ Deploy Preview for react-plock canceled.
|
|
Hi @ramit-mitra thanks for the PR. Can i ask you to amend your commit using this style? Because the CI will look at the fix: prefix to create a new release. Another question, is it possible for you to write a test case for this particular event? Thanks |
ramit-mitra
changed the title
|
Hey @itsrennyman, |
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.