Fix finish_reason for chat model for non-streaming case. (#7)

@asklar - I just copy/pasted the fix from d41216a but haven't tested it - hopefully you have an easy way to do that.
asklar · Apr 13, 2023 · 46fb78d · 46fb78d
1 parent d41216a
commit 46fb78d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/OpenAI.WinRT.nuspec b/OpenAI.WinRT.nuspec
@@ -2,7 +2,7 @@
 <package >
   <metadata>
     <id>OpenAI.WinRT</id>
-    <version>0.0.12</version>
+    <version>0.0.13</version>
     <title>OpenAI.WinRT</title>
     <authors>Alexander Sklar</authors>
     <requireLicenseAcceptance>false</requireLicenseAcceptance>

diff --git a/OpenAIClient.cpp b/OpenAIClient.cpp
@@ -477,13 +477,18 @@ namespace winrt::OpenAI::implementation
             auto msg = choice.GetNamedObject(L"message");
             retChoiceImpl->m_text = msg.GetNamedString(L"content");
           }
-          auto finish_reason = choice.GetNamedString(L"finish_reason");
-          if (finish_reason == L"stop") {
-            retChoiceImpl->m_finishReason = FinishReason::Stop;
-          } else if (finish_reason == L"length") {
-            retChoiceImpl->m_finishReason = FinishReason::Length;
-          } else {
-            throw winrt::hresult_invalid_argument{};
+          if (choice.HasKey(L"finish_reason")) {
+            auto fr = choice.GetNamedValue(L"finish_reason");
+            auto finish_reason = fr.ValueType() == JsonValueType::String ? fr.GetString() : L"stop";
+            if (finish_reason == L"stop") {
+              retChoiceImpl->m_finishReason = FinishReason::Stop;
+            }
+            else if (finish_reason == L"length") {
+              retChoiceImpl->m_finishReason = FinishReason::Length;
+            }
+            else {
+              throw winrt::hresult_invalid_argument{};
+            }
           }
           retChoices.push_back(retChoice);
         }