perf(orama): improve speed of heavy tasks #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ilteoood
commented
Apr 4, 2024
|
Wow! Thank you Matteo! Please make sure to format the code correctly by running Will review this ASAP |
|
@micheleriva version 1.4.1 of biome was not working on GitHub codespaces. I upgraded it to the latest one (1.6.4) and executed the |
|
I see a performance improvement of 5% in some cases during the search. |
|
This is awesome |
micheleriva
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I would like to make some code changes in order to improve Orama's speed during heavy operations, like:
Additionally, since I don't know the details of Orama's codebase, I have inserted a couple of comments for future improvements that I can do in this PR or in another one.
Note for the reviewers: the only changes I made are in the
oramapackage. Everything else is related to formatting fixes made by the biome upgrade