Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a pipeline and some unit tests ? #34

Open
wassef911 opened this issue Feb 18, 2023 · 6 comments
Open

add a pipeline and some unit tests ? #34

wassef911 opened this issue Feb 18, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@wassef911
Copy link

any suggestions on what to use? Mocha? Tape?
@navopw
Copy link
Collaborator

navopw commented Feb 18, 2023

Mocha would be great :)

@navopw navopw added the enhancement New feature or request label Feb 18, 2023
@jwalahe
Copy link

jwalahe commented Feb 19, 2023

+1

Are you aiming for 80% global coverage? @navopw @wassef911

@navopw
Copy link
Collaborator

navopw commented Feb 19, 2023

Would be nice but this project is currently in rapid development phase.

Will start with the tests in a few days :D

@navopw
Copy link
Collaborator

navopw commented Feb 19, 2023

There already was a PR for tests but I had to decline because the methods changed.

#49

Will merge this sooner or later tho.

@jwalahe
Copy link

jwalahe commented Feb 19, 2023 via email

@wassef911
Copy link
Author

understood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@navopw @wassef911 @jwalahe