Drilldown #1
Merged
Drilldown #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Alek12313 and @yevgenstylo, please review |
Alek12313
approved these changes
Sep 20, 2021
Alek12313
reviewed
Sep 20, 2021
|
hi @evilrw I fixed all the files as in [Get Drilldown Poc to Compile] (b057d59) Drilldown power. Do you have any ideas for me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃弳 Enhancements
See writeup on askstylo/superset#1. These changes are the non superset-ui changes meant to support those.
As with that PR, this one for the most part draws from apache/superset#14688. There were a few changes necessary to support doing the same thing, but in the nvd3 chart family instead of the echarts family.