Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parser to work with forward slashes in ref param #124

Merged
merged 2 commits into from Nov 11, 2020
Merged

fix: parser to work with forward slashes in ref param #124

merged 2 commits into from Nov 11, 2020

Conversation

DzeryCZ
Copy link
Contributor

@DzeryCZ DzeryCZ commented Nov 8, 2020 •
edited by aslafy-z

Fixes #123

@ion-munteanu-x
Copy link

@DzeryCZ Is it possible to merge this?

@ion-munteanu-x
Copy link

Tested and it works fine, btw.

@DzeryCZ
Copy link
Contributor Author

DzeryCZ commented Nov 11, 2020

Yep. If it looks good to you please merge.
Thanks.

@aslafy-z aslafy-z changed the title Issue #123 : Fix parser to work with forward slashes in ref param fix: parser to work with forward slashes in ref param Nov 11, 2020
@aslafy-z aslafy-z merged commit 1b269f7 into aslafy-z:master Nov 11, 2020
@aslafy-z
Copy link
Owner

Thanks for your contribution! Will release ASAP

aslafy-z pushed a commit that referenced this pull request Nov 11, 2020
@DzeryCZ @aslafy-z
fix: parser to work with forward slashes in ref param (#124)
00697dd
@aslafy-z
Copy link
Owner

https://github.com/aslafy-z/helm-git/releases/tag/v0.9.0 was released and includes this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ion-munteanu-x ion-munteanu-x ion-munteanu-x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Plugin does not work when git ref contains a forward slash
3 participants
@DzeryCZ @ion-munteanu-x @aslafy-z