-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'keyup .reactive-table-filter input' finer grain target #72
Comments
aslagle
added a commit
that referenced
this issue
Jun 2, 2014
An id would cause problems for anyone using multiple tables, but I added a class to those inputs to make the selector more specific. |
Good point. Class should suffice perfectly for any use case and also is more targeted for those injecting other fields into the filter div. |
aramk
added a commit
to aramk/reactive-table
that referenced
this issue
Jul 2, 2014
…e-table into feature/selectable # By Amy Slagle (7) and others # Via Amy Slagle * 'master' of https://github.com/ecohealthalliance/reactive-table: Increase version number. Added `sortByValue` explanation to README Added sortByValue field option, allowing function-generated fields to be sorted by their original value Add additional class for filter event selectors (aslagle#72). Increase version number. Support for collection-helpers Increase version number. fix get function to prevent aslagle#11 safer get function Increase version number. Cleaned up semicolons and paren spacing Minor typo fix Added ability to set default sorting field and direction Add Turkish to README and reformat language list. Increase version number. fix Turkish translation add Turkish translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
'keyup .reactive-table-filter input' should be targeted to an id rather than the input so that people can inject other html input elements into the reactive-table-filter.
For example, I am injecting a start and end date date selector into the reactive-table-filter and when I select a start or end date the 'keyup .reactive-table-filter input' is firing.
If this was tightly bound to an id of filter then people could inject other input elements into the filter div in order to enable server side subscription management.
For example, my start and end date html fragments injected fire their event handlers to be used in the autorun subscription.
The text was updated successfully, but these errors were encountered: