it gets the version from the parent if it doesnt exit

aslakhellesoy · Mar 24, 2010 · f5ee4a1 · f5ee4a1
1 parent ee7bb76
commit f5ee4a1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 52 deletions.
diff --git a/lib/maven_gem/pom_spec.rb b/lib/maven_gem/pom_spec.rb
@@ -65,7 +65,7 @@ def self.parse_pom(pom_doc, options = {})
 
       pom.group = xpath_group(document)
       pom.artifact = xpath_text(document, '/project/artifactId')
-      pom.maven_version = xpath_text(document, '/project/version')
+      pom.maven_version = xpath_text(document, '/project/version') || xpath_text(document, '/project/parent/version')
       pom.version = maven_to_gem_version(pom.maven_version)
       pom.description = xpath_text(document, '/project/description')
       pom.url = xpath_text(document, '/project/url')

diff --git a/maven_gem.gemspec b/maven_gem.gemspec
diff --git a/spec/maven_gem/pom_spec_spec.rb b/spec/maven_gem/pom_spec_spec.rb
@@ -111,6 +111,14 @@
       pom.jar_file.should == 'ant-1.6.6-SNAPSHOT.jar'
       pom.gem_file.should == 'ant.ant-1.6.6-java.gem'
     end
+
+    it "uses the version from the parent when its version doesn't exit" do
+      pom = MavenGem::PomFetcher.fetch(File.join(FIXTURES, 'hudson-rake.pom'))
+      pom_without_version = pom.gsub(/<version>1.7-SNAPSHOT<\/version>/, '')
+
+      pom_spec = MavenGem::PomSpec.parse_pom(pom_without_version)
+      pom_spec.version.should == '1.319'
+    end
   end
 
   describe "generate_spec" do