Adding ability to add description to RegisteredModel #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aslotte I've kept this simple and just added a string property for now. Let me know if you have any feedback :) |
aslotte
approved these changes
Aug 15, 2020
There was a problem hiding this comment.
Great work @willvelida! We can add some method overload methods in an upcoming PR (to not provide a description if the user doesn't want to) but I think this is great 👍
Thank you for your contribution and welcome to the MLOps.NET team!
aslotte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Fixes #220 by adding a string field for description to the
RegisteredModelclass.Description
In this PR, There is now a string property in the
RegisteredModelclass that allows users to add a basic description to the model.Unit Tests have also been updated.