twig >1.16.2 #11
Closed
twig >1.16.2 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,6 +9,8 @@ | |||
| * file that was distributed with this source code. | |||
| */ | |||
|
|
|||
| error_reporting(E_ALL | E_STRICT); | |||
There was a problem hiding this comment.
Not sure about this line. I just added this to make sure the notice for getTestNodeClass() will be thrown when running phpunit.
|
👍 i need this |
|
@asm89 any chance for this to be merged? |
|
any news? :) |
|
@asm89 we need it for our library. So we fork your project with this pull request. https://github.com/simpspector/twig-lint If you have resolved the problem, we will change it back. 😉 |
|
@DavidBadura @tolry Sorry this took so looooooooooooooooong, but I'm back. :) I squashed this and committed it here: 5b74dc5. |
|
great, thx |
|
@asm89 will you release a new version for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I suggested in #9 it would be possible to have two versions of twig-lint to work around the API changes currently breaking with twig >1.16.2
This version is tested with 1.17, if this solution would be a possibility for you, @asm89, I would test all versions in between.
Ideas, suggestions?