Fix YAML dump/load cycle inside SexpFormatter.format.

lib/reek/source/sexp_formatter.rb

@@ -9,7 +9,7 @@ module Source
     class SexpFormatter
       def self.format(sexp)
         return sexp.to_s unless Array === sexp
-        sexp = YAML::load(YAML::dump(sexp))
+        sexp = Sexp.from_array(YAML::load(YAML::dump(sexp)))
         Ruby2Ruby.new.process(sexp)
       end
     end

spec/reek/source/sexp_formatter_spec.rb

@@ -0,0 +1,19 @@
+require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'source', 'sexp_formatter')
+
+include Reek::Source
+
+describe SexpFormatter do
+  describe "::format" do
+    it 'formats a simple s-expression' do
+      result = SexpFormatter.format s(:lvar, :foo)
+      result.should == "foo"
+    end
+
+    it 'formats a more complex s-expression' do
+      result = SexpFormatter.format s(:call, nil, :foo, s(:arglist, s(:lvar, :bar)))
+      result.should == "foo(bar)"
+    end
+  end
+end
+