Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] RTL with loop #241

Closed
sinchang opened this issue Jun 30, 2023 · 3 comments
Closed

[BUG] RTL with loop #241

sinchang opened this issue Jun 30, 2023 · 3 comments
Assignees
@asmyshlyaev177

Comments

@sinchang
Copy link

see the demo https://codesandbox.io/s/loop-scroll-forked-yxkskw?file=/src/index.tsx

We can't click the left arrow button in RTL mode.

Appreciate it if we could add the demo about RTL with the loop feature
@asmyshlyaev177 asmyshlyaev177 self-assigned this Jan 25, 2024
@asmyshlyaev177
Copy link
Owner

asmyshlyaev177 commented Jan 28, 2024 •
edited
Loading

Sorry for the delay, I will look into it. But this requires writing better tests and possibly complex refactoring.
Can try to pass noPolyfill option, there is issue with lib that used scroll-into-view/scroll-into-view-if-needed#993

asmyshlyaev177 added a commit that referenced this issue Jan 29, 2024
@asmyshlyaev177
fix(rtl): fix noPolyfill arg in scrollToItem
3fdaef3 
#241
asmyshlyaev177 added a commit that referenced this issue Jan 29, 2024
@asmyshlyaev177
RtL bug 241 (#263)
09cf1df 
* chore: remove console

* chore: fix types for scroll behavior

* fix(rtl): fix noPolyfill arg in scrollToItem

#241
@asmyshlyaev177
Copy link
Owner

Fixed in #263 , please update to the latest version.

@asmyshlyaev177
Copy link
Owner

asmyshlyaev177 commented Jan 29, 2024 •
edited
Loading

Take a look into example in storybook https://asmyshlyaev177.github.io/react-horizontal-scrolling-menu/?path=/story/examples-rtl--rtl ,
Notice that noPolyfill option is required for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asmyshlyaev177 asmyshlyaev177

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sinchang @asmyshlyaev177