Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating deployment to fix resources positioning in deployment file #136

Conversation

syedimam0012
Copy link

This is to fix an issue that's relevant only in the context of having resources set for kube-monkey

PROBLEM

When running helm install --name my-release kubemonkey it returns
unable to CREATE Deployment: no spec.template.spec.containers[*].resources set,.

WHY?

This is because the resources appear under volume as per the current deployment definition.

FIX

This is to update the deployment so that it looks like spec -> containers -> resources

NOTE

An instance of kube-monkey has been deployed successfully with modified deployment

@asobti
Copy link
Owner

asobti commented Dec 26, 2018

Nice catch. Thanks for fixing this.

@prageethw As the original author of the helm charts, could you review this as well?

@asobti asobti assigned asobti and unassigned asobti Dec 26, 2018
@syedimam0012
Copy link
Author

Hi @asobti , pleasure indeed. Thanks for approving this and hope @prageethw takes a look and advise accordingly.

@asobti asobti merged commit ceddb3c into asobti:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants