Improve handling of filenames with multiple dots in path extraction #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to express my gratitude for the work you've done on the projectile-rails library, which is a valuable tool for the Rails community.
I'm submitting this pull request to address an issue with the path extraction of filenames containing multiple dots. The current implementation of the
projectile-rails-extract-region
function does not effectively handle filenames with multiple dots, leading to incorrect file path extraction.I've updated the function to use a regular expression with
replace-regexp-in-string
, replacing thes-slice-at
method. This change ensures more accurate handling of filenames with multiple periods, improving the function's robustness.I've been using this change in my actual work environment for some time without any issues, although it hasn't been extensively tested. I believe this update will be beneficial to other users as well.
Thank you for considering this pull request.