Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of filenames with multiple dots in path extraction #169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ichiroc
Copy link

@ichiroc ichiroc commented Jan 9, 2024

I would like to express my gratitude for the work you've done on the projectile-rails library, which is a valuable tool for the Rails community.

I'm submitting this pull request to address an issue with the path extraction of filenames containing multiple dots. The current implementation of the projectile-rails-extract-region function does not effectively handle filenames with multiple dots, leading to incorrect file path extraction.

I've updated the function to use a regular expression with replace-regexp-in-string, replacing the s-slice-at method. This change ensures more accurate handling of filenames with multiple periods, improving the function's robustness.

I've been using this change in my actual work environment for some time without any issues, although it hasn't been extensively tested. I believe this update will be beneficial to other users as well.

Thank you for considering this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant