Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class-level if TYPE_CHECKING is reported as uncovered #96

Closed
sobolevn opened this issue Dec 3, 2022 · 0 comments · Fixed by #97
Closed

Class-level if TYPE_CHECKING is reported as uncovered #96

sobolevn opened this issue Dec 3, 2022 · 0 comments · Fixed by #97

Comments

@sobolevn
Copy link
Contributor

sobolevn commented Dec 3, 2022

Example:

from typing import TYPE_CHECKING

class Some:
   if TYPE_CHECKING:
      some_attr: str

Here if TYPE_CHECKING: is reported to be uncovered.

Снимок экрана 2022-12-03 в 14 21 00

While, other rules have \s* prefix. I have a PR ready.
sobolevn added a commit to sobolevn/covdefaults that referenced this issue Dec 3, 2022
@sobolevn
Do not report class level if TYPE_CHECKIN as uncovered
3855e6e 
Closes asottile#96
@sobolevn sobolevn mentioned this issue Dec 3, 2022
Merged
asottile pushed a commit to sobolevn/covdefaults that referenced this issue Dec 3, 2022
@sobolevn @asottile
Do not report class level if TYPE_CHECKIN as uncovered
26e9e20 
Closes asottile#96
asottile pushed a commit to sobolevn/covdefaults that referenced this issue Dec 3, 2022
@sobolevn @asottile
Do not report class level if TYPE_CHECKING as uncovered
f586651 
Closes asottile#96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not report class level if TYPE_CHECKING as uncovered sobolevn/covdefaults
1 participant
@sobolevn