Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use onig-config to get library/include dirs #74

Closed
wants to merge 2 commits into from

Conversation

jrjsmrtn
Copy link

@jrjsmrtn jrjsmrtn commented Oct 8, 2021

This fixes #72 in a more standard way than #73, by using onig-config.

@asottile
Copy link
Owner

asottile commented Oct 8, 2021

I'd rather not add the complexity for nonstandard build situations

@jrjsmrtn
Copy link
Author

jrjsmrtn commented Oct 8, 2021

I'd rather not add the complexity for nonstandard build situations

I don't understand ??? :-/

Using the MacPorts or Homebrew package managers is pretty standard on macOS. Using onig-config to get the onigurama config also seems pretty standard to me.

On the win32 platform, you configure dirs to get to the ONIGURAMA_CLONE installation.

Could you please reconsider ? I'm trying to get help and help building oniguramacffi on macOS here... and using CPATH is not a standard way of installing... :-/

@asottile
Copy link
Owner

asottile commented Oct 8, 2021

it already works fine with homebrew

@jrjsmrtn
Copy link
Author

jrjsmrtn commented Oct 8, 2021

it already works fine with homebrew

OK, good to know... I had no macOS with Homebrew to test, I just checked the onigurama recipe.

But my issue and PR are with MacPorts, which a lot of people are also using. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MacPorts oniguruma6 include not found
2 participants