Merge pull request #628 from asottile/capture_output_text

rewrite check_output(...) universal_newlines -> text
asottile · Apr 8, 2022 · 181f29d · 181f29d
2 parents e4f7820 + a1d1fd7
commit 181f29d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/pyupgrade/_plugins/subprocess_run.py b/pyupgrade/_plugins/subprocess_run.py
@@ -73,7 +73,7 @@ def visit_Call(
                 node.func,
                 state.from_imports,
                 ('subprocess',),
-                ('run',),
+                ('check_output', 'run'),
             )
     ):
         stdout_idx = None

diff --git a/tests/features/universal_newlines_to_text_test.py b/tests/features/universal_newlines_to_text_test.py
@@ -65,6 +65,15 @@ def test_fix_universal_newlines_to_text_noop(s, version):
 
             id='subprocess.run attribute',
         ),
+        pytest.param(
+            'import subprocess\n'
+            'subprocess.check_output(["foo"], universal_newlines=True)\n',
+
+            'import subprocess\n'
+            'subprocess.check_output(["foo"], text=True)\n',
+
+            id='subprocess.check_output attribute',
+        ),
         pytest.param(
             'from subprocess import run\n'
             'run(["foo"], universal_newlines=True)\n',