Enable linting of stub files (.pyi) in pre-commit hook
#771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable support for `pyi` files when using `pyupgrade` through `pre-commit`. This will run pyupgrade on stub files in addition to source files. References: 1. [The same file on black](https://github.com/psf/black/blob/main/.pre-commit-hooks.yaml) 2. [pre-commit docs](https://github.com/psf/black/blob/main/.pre-commit-hooks.yaml)
Apakottur
changed the title
pyi files in pre-commit.pyi) in pre-commit hook
Apakottur
added a commit
to Apakottur/absolufy-imports
that referenced
this pull request
Dec 21, 2022
Enable support for `pyi` files when using `absolufy-imports` through `pre-commit`. This will run absolufy-imports on stub files in addition to source files. References: 1. [The same file on black](https://github.com/psf/black/blob/main/.pre-commit-hooks.yaml) 2. [pre-commit docs](https://github.com/psf/black/blob/main/.pre-commit-hooks.yaml) 3. [Same PR on pyupgrade](asottile/pyupgrade#771)
Apakottur
added a commit
to Apakottur/flake8
that referenced
this pull request
Dec 21, 2022
Enable support for `pyi` files when using `flake8` through `pre-commit`. This will run flake8 on stub files in addition to source files. Note that by default flake8 doesn't run checks on `pyi` files, and most commonly the [flake8-pyi plugin](https://pypi.org/project/flake8-pyi/) is used to enable those files types and check them. However, without the change in the pre-commit config file, the stub files are still ignored. References: 1. [The same file on black](https://github.com/psf/black/blob/main/.pre-commit-hooks.yaml) 2. [pre-commit docs](https://github.com/psf/black/blob/main/.pre-commit-hooks.yaml) 3. [Same PR on pyupgrade](asottile/pyupgrade#771)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable support for
pyifiles when usingpyupgradethroughpre-commit. This will run pyupgrade on stub files in addition to source files.References: