Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --show-diff flag #5

Closed
dinoshauer opened this issue Jan 2, 2015 · 2 comments
Closed

Add --show-diff flag #5

dinoshauer opened this issue Jan 2, 2015 · 2 comments

Comments

@dinoshauer
Copy link
Contributor

Hey there, a --show-diff option (or, another non-modifying way) of running reorder-python-imports would be really nice to have. It's really the only request I have for this, I didn't use the other parameters in isort.

I will be referencing your repo on https://github.com/FalconSocial/pre-commit-python-sorter to redirect people here as this doesn't have the same PATH requirements as isort does.
@dinoshauer dinoshauer mentioned this issue Jan 2, 2015
Merged
asottile added a commit that referenced this issue Jan 2, 2015
@asottile
Add --diff-only argument. Closes #5
01d019c
@asottile
Copy link
Owner

asottile commented Jan 2, 2015

aww dangit, teach me to refresh more often >.< looks like we both implemented this

@dinoshauer
Copy link
Contributor Author

Haha, oh dear!

asottile added a commit that referenced this issue Jan 2, 2015
@asottile
Merge pull request #7 from asottile/diff_only_issue_5
3897127 
Add --diff-only argument.  Closes #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asottile @dinoshauer