Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow directories as input #76

Closed
wants to merge 1 commit into from

Conversation

juanrgon
Copy link

@juanrgon juanrgon commented Apr 8, 2019

This PR allows for directories to be used as input to reorder-python-imports.

@asottile
Copy link
Owner

asottile commented Apr 8, 2019

The intention is to run the tool through pre-commit which means every tool in the world doesn't have to reimplement:

  • file matching (complicated, involves exclusion / inclusion / recursion / etc.)
  • dry run / diff / etc.

I don't have an interest in supporting these complicated options in each and every tool, pre-commit run --all-files does a much better job than any tool could since it only will run against git tracked files (and the hook metadata configures what is included vs excluded). pre-commit run --all-files --show-diff-on-failure is the intended CI tool as well, which (as you'd expect) shows a diff.

See also:

@asottile asottile closed this Apr 8, 2019
@juanrgon
Copy link
Author

juanrgon commented Apr 8, 2019

👍 I'll use my fork going forward

Repository owner locked as resolved and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants