Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): add unique function #716

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Conversation

mgred
Copy link
Contributor

@mgred mgred commented Jan 9, 2024

Add a function that returns a list with unique items. I find this function quite useful and use it here and there. What do you think?

Type of change

  • New feature or functionality (change which adds functionality)

For changes visible to end-users

  • Relevant documentation has been updated

Test plan

  • New test cases added

lib/private/lists.bzl Outdated Show resolved Hide resolved
@alexeagle alexeagle enabled auto-merge (squash) February 27, 2024 16:24
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I don't have more time for bikeshedding on this, I think it's fine as we don't have any users of it yet.

@alexeagle alexeagle merged commit a3d7efe into aspect-build:main Feb 27, 2024
32 checks passed
@mgred mgred deleted the add-unique branch February 27, 2024 17:22
gregmagolan pushed a commit that referenced this pull request Mar 27, 2024
* feat(list): add `unique` function

* Update lists.bzl

* Update lists.bzl

* Update lists.bzl

* Update lists.bzl

---------

Co-authored-by: Alex Eagle <alex@aspect.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants