chore: make it possible to override run_binary#use_default_shell_env #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
reviewed
Feb 21, 2024
Still not documented as public API. We think this leads to non-hermeticity and could cause cache misses, so it must be used with care. Part of aspect-build/rules_js#1303
alexeagle
force-pushed
the
default_shell_env
branch
from
34fff49
to
fe84cda
Compare
jbedard
approved these changes
Feb 21, 2024
gregmagolan
pushed a commit
that referenced
this pull request
Mar 5, 2024
…762) Still not documented as public API. We think this leads to non-hermeticity and could cause cache misses, so it must be used with care. Part of aspect-build/rules_js#1303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still not documented as public API. We think this leads to non-hermeticity and could cause cache misses, so it must be used with care.
Part of aspect-build/rules_js#1303
Type of change
Test plan
Added a trivial usage.