Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tar#srcs is optional #785

Merged
merged 1 commit into from
Mar 8, 2024
Merged

fix: tar#srcs is optional #785

merged 1 commit into from
Mar 8, 2024

Conversation

thesayyn
Copy link
Member

@thesayyn thesayyn commented Mar 8, 2024

Type of change

  • Bug fix (change which fixes an issue)

Test plan

  • Covered by existing test cases
Allows users to type without explicitly setting srcs to []

tar(
  name = "tmp",
  mtree = ["..."]
)

@thesayyn thesayyn merged commit d93c87f into main Mar 8, 2024
70 checks passed
@thesayyn thesayyn deleted the thesayyn-patch-1 branch March 8, 2024 01:44
@thesayyn thesayyn mentioned this pull request Mar 8, 2024
Merged
gregmagolan pushed a commit that referenced this pull request Mar 23, 2024
@thesayyn @gregmagolan
fix: tar#srcs is optional (#785)
cc14595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@jbedard jbedard jbedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thesayyn @alexeagle @jbedard