Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enforce PR titles are semantic #823

Merged
merged 1 commit into from
Apr 24, 2024
Merged

ci: enforce PR titles are semantic #823

merged 1 commit into from
Apr 24, 2024

Conversation

alexeagle
Copy link
Member

We want contributors to follow the instructions in the PR template, and use conventional commits to indicate the type of the PR.

Note, this uses the amannn upstream to check the title. We could use aspect-forks instead to check the description as well: https://github.com/aspect-forks/action-semantic-pull-request/blob/main/src/validatePrDescription.js


Changes are visible to end-users: no

Test plan

  • Manual testing; please provide instructions so we can reproduce:

will observe it running

We want contributors to follow the instructions in the PR template, and use conventional commits to indicate the type of the PR.

Note, this uses the amannn upstream to check the title. We could use aspect-forks instead to check the description as well: https://github.com/aspect-forks/action-semantic-pull-request/blob/main/src/validatePrDescription.js
Copy link

aspect-workflows bot commented Apr 24, 2024

Test

3 test targets passed

Targets
//lib/tests/copy_to_directory_bin_action:test [k8-opt] 87ms
//lib/tests/jq:check_stamped [k8-opt]                  121ms
//lib/tests/yq:check_stamped [k8-opt]                  22ms

Total test execution time was 230ms. 224 tests (98.7%) were fully cached saving 39s.


Test

e2e/copy_to_directory

Waiting for runner...


Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 578ms.


Test

e2e/external_copy_to_directory

⚠️ CircleCI build #3288 failed.

@com_github_bmatcuk_doublestar_v4//:doublestar failed to build

no such package '@com_github_bmatcuk_doublestar_v4//': no such package
'@bazel_gazelle_go_repository_config//': no such package '@bazel_gazelle_go_repository_tools//':
list_repository_tools_srcs: Timed out

@org_golang_x_exp//maps:maps failed to build

no such package '@org_golang_x_exp//maps': no such package '@bazel_gazelle_go_repository_config//': no such
package '@bazel_gazelle_go_repository_tools//': list_repository_tools_srcs: Timed out

💡 To reproduce the build failures, run

bazel build @com_github_bmatcuk_doublestar_v4//:doublestar @org_golang_x_exp//maps:maps

Test

e2e/smoke

⚠️ CircleCI build #3288 failed.

@com_github_bmatcuk_doublestar_v4//:doublestar failed to build

no such package '@com_github_bmatcuk_doublestar_v4//': no such package
'@bazel_gazelle_go_repository_config//': no such package '@bazel_gazelle_go_repository_tools//': failed to
build tools: Timed out

@org_golang_x_exp//maps:maps failed to build

no such package '@org_golang_x_exp//maps': no such package '@bazel_gazelle_go_repository_config//': no such
package '@bazel_gazelle_go_repository_tools//': failed to build tools: Timed out
no such package '@org_golang_x_exp//maps': no such package '@bazel_gazelle_go_repository_config//': no such
package '@bazel_gazelle_go_repository_tools//': failed to build tools: Timed out

💡 To reproduce the build failures, run

bazel build @com_github_bmatcuk_doublestar_v4//:doublestar @org_golang_x_exp//maps:maps

Buildifier      Format      Gazelle

@alexeagle alexeagle merged commit 223b278 into main Apr 24, 2024
68 of 71 checks passed
@alexeagle alexeagle deleted the alexeagle-patch-1 branch April 24, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants