Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register @zstd_toolchains//:all #832

Merged
merged 1 commit into from
May 4, 2024
Merged

fix: register @zstd_toolchains//:all #832

merged 1 commit into from
May 4, 2024

Conversation

thesayyn
Copy link
Member

@thesayyn thesayyn commented May 4, 2024

I don't know why Bazel did not complain that the toolchain wasn't registered.

Changes are visible to end-users: yes/no

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: no

Test plan

  • Covered by existing test cases

@thesayyn thesayyn requested a review from alexeagle May 4, 2024 04:10
Copy link

aspect-workflows bot commented May 4, 2024

Test

3 test targets passed

Targets
//lib/tests/copy_to_directory_bin_action:test [k8-opt] 69ms
//lib/tests/jq:check_stamped [k8-opt]                  89ms
//lib/tests/yq:check_stamped [k8-opt]                  16ms

Total test execution time was 174ms. 227 tests (98.7%) were fully cached saving 39s.


Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 660ms.


Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 578ms.


Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 52ms.


Test

e2e/smoke

All tests were cache hits

6 tests (100.0%) were fully cached saving 1s.


Buildifier      Format      Gazelle

@thesayyn
Copy link
Member Author

thesayyn commented May 4, 2024

I know why, because we don't have a WORKSPACE.bzlmod file so WORKSPACE gets evaluated alongside bzlmod...

@alexeagle alexeagle merged commit fdf3be1 into main May 4, 2024
70 of 71 checks passed
@alexeagle alexeagle deleted the thesayyn-patch-2 branch May 4, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants