Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup and align npm_link_package* tests #434

Closed
jbedard opened this issue Sep 6, 2022 · 0 comments · Fixed by #444
Closed

cleanup and align npm_link_package* tests #434

jbedard opened this issue Sep 6, 2022 · 0 comments · Fixed by #444
Assignees
@jbedard

Comments

@jbedard
Copy link
Member

jbedard commented Sep 6, 2022

  • align them again, new test scenarios were added to one
  • try removing the "/index.js" from imports in the esm test
  • why was --experimental-json-modules added? maybe add json importing?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbedard jbedard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: align commonjs + esm npm_link_package tests jbedard/rules_js
1 participant
@jbedard