fix: support transitive npm aliased deps in pnpm lockfile #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
support_transitive_alises
branch
2 times, most recently
from
204f85f
to
7ece3c5
Compare
alexeagle
approved these changes
Jun 13, 2022
| @@ -1,2 +1,7 @@ | |||
| e2e/ | |||
| examples/node_modules/ | |||
| examples/assert_lockfile_up_to_date/node_modules/ | |||
There was a problem hiding this comment.
nit: could add a test that this file and pnpm-workspace.yaml agree on the node_modules folder locations
There was a problem hiding this comment.
agreed; it is annoying that it is can easily fall out of date; users should do the same
There was a problem hiding this comment.
will make an issue to do as a follow-up
gregmagolan
force-pushed
the
support_transitive_alises
branch
from
7ece3c5
to
9acf28f
Compare
gregmagolan
force-pushed
the
support_transitive_alises
branch
from
868a8e7
to
46c47ca
Compare
gregmagolan
force-pushed
the
support_transitive_alises
branch
from
46c47ca
to
8abf07a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164