Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add sh_test for ls-files function #216

Merged
merged 2 commits into from Apr 24, 2024
Merged

chore: add sh_test for ls-files function #216

merged 2 commits into from Apr 24, 2024

Conversation

alexeagle
Copy link
Member

It caught an issue when no files are found, we cannot run git check-attr

Type of change

  • Chore (any other change that doesn't affect source or test files, such as configuration)

Test plan

  • New test cases added

@alexeagle
chore: add sh_test for ls-files function
631301c 
It caught an issue when no files are found, we cannot run git check-attr
@alexeagle alexeagle requested a review from mrmeku April 23, 2024 01:52
mrmeku
mrmeku approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@mrmeku mrmeku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on the code. You'll need to update the directory you're sourcing from though to make CI pass

format/private/format.sh Outdated Show resolved Hide resolved
@alexeagle
refactor: put it back in a single script
7ef5b07 
sh_library -> sh_binary is a lie, there's no good way to dynamic link at runtime
@alexeagle alexeagle merged commit 7505e28 into main Apr 24, 2024
8 checks passed
@alexeagle alexeagle deleted the add_git_test branch April 24, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmeku mrmeku mrmeku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexeagle @mrmeku