generated from bazel-contrib/rules-template
-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): plumb exit codes as outputs rather than dropping them #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loor This allows downstream tools to return a correct exit code based on 'errors were reported by at least one linter'
alexeagle
force-pushed
the
exit_codes
branch
4 times, most recently
from
May 8, 2024 21:03
f3d5a84
to
94b547b
Compare
When running it to produce patches we need to ignore its exit code.
gregmagolan
reviewed
May 8, 2024
gregmagolan
reviewed
May 8, 2024
gregmagolan
reviewed
May 8, 2024
gregmagolan
reviewed
May 9, 2024
gregmagolan
reviewed
May 9, 2024
gregmagolan
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧙
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows downstream tools to return a correct exit code based on 'errors were reported by at least one linter'
Also fixes our bug where "empty output" is assumed to mean success, which was forcing us to stay on an older version of ruff.
Note that
lint.sh
doesn't try to read these files and exit with the right code. I don't really care about that right now, but will file an issue to come back to it.Work towards #86
Changes are visible to end-users: yes
It's only slightly visible, in that
lint.sh
now prints exit codes as well:Test plan