Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SWC to re-enable sandbox #61

Closed
bazaglia opened this issue Jul 21, 2022 · 4 comments
Closed

Update SWC to re-enable sandbox #61

bazaglia opened this issue Jul 21, 2022 · 4 comments
Labels
cleanup Cleanup task

Comments

@bazaglia
Copy link

Now that swc-project/swc#4057 has been closed, if the SWC binary being used by rules_swc is updated to v1.2.218, it should be possible to remove the flag that disables the sandbox:

rules_swc/.bazelrc

Lines 6 to 8 in 29f5a69

# Workaround for https://github.com/swc-project/swc/issues/4057
# Turn off sandboxing so SWC doesn't observe symlinked inputs.
build --modify_execution_info=SWCTranspile=+no-sandbox

alexeagle added a commit that referenced this issue Oct 20, 2022
The symlink issue upstream was fixed.
Fixes #61
alexeagle added a commit that referenced this issue Oct 20, 2022
The symlink issue upstream was fixed.
Fixes #61
@alexeagle
Copy link
Member

I took a stab at this: https://github.com/aspect-build/rules_swc/pull/97/files#r1000754748

but seems like there's still an SWC bug :(

@realtimetodie
Copy link
Contributor

I'm working on this

@alexeagle
Copy link
Member

Looks like we're just waiting on the next SWC release and we can fix this.
It doesn't need to be a breaking change, we just document that users still have to use the workaround if their swc version is less than X

@alexeagle
Copy link
Member

fixed in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants