fix: Sourcemap links are not generated #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realtimetodie
force-pushed
the
source-mapping-url
branch
from
e8a8749
to
518797f
Compare
realtimetodie
commented
Jan 30, 2023
|
I fixed another issue. The .swrc configuration file auto-discovery did not work properly, as the value needs to be of type label. Line 73 in 518797f |
|
With regard to the source map test cases, everything works now as it did previously, except swc-project/swc#1388 which is something I found while going through the @swc/cli source code. |
alexeagle
reviewed
Jan 31, 2023
gregmagolan
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the sourceMappingURL comment was not added to the output.
Fixes #146