feat: wire up attribute validator for isolated_declaration

aspect-build · Jul 1, 2024 · ff98e7a · ff98e7a
1 parent 600f9eb
commit ff98e7a
Show file tree

Hide file tree

Showing 10 changed files with 3 additions and 65 deletions.
diff --git a/examples/isolatedDeclarations/BUILD.bazel b/examples/isolatedDeclarations/BUILD.bazel
diff --git a/examples/isolatedDeclarations/README.md b/examples/isolatedDeclarations/README.md
diff --git a/examples/isolatedDeclarations/backend/BUILD.bazel b/examples/isolatedDeclarations/backend/BUILD.bazel
diff --git a/examples/isolatedDeclarations/backend/index.ts b/examples/isolatedDeclarations/backend/index.ts
diff --git a/examples/isolatedDeclarations/core/index.ts b/examples/isolatedDeclarations/core/index.ts
diff --git a/examples/isolatedDeclarations/frontend/index.ts b/examples/isolatedDeclarations/frontend/index.ts
diff --git a/examples/isolatedDeclarations/tsconfig.json b/examples/isolatedDeclarations/tsconfig.json
diff --git a/ts/defs.bzl b/ts/defs.bzl
@@ -281,6 +281,7 @@ def ts_project(
         source_map = compiler_options.setdefault("sourceMap", source_map)
         declaration = compiler_options.setdefault("declaration", declaration)
         declaration_map = compiler_options.setdefault("declarationMap", declaration_map)
+        isolated_declarations = compiler_options.setdefault("isolatedDeclarations", isolated_declarations)
         emit_declaration_only = compiler_options.setdefault("emitDeclarationOnly", emit_declaration_only)
         allow_js = compiler_options.setdefault("allowJs", allow_js)
         if resolve_json_module != None:

diff --git a/ts/private/ts_project_options_validator.js b/ts/private/ts_project_options_validator.js
@@ -170,6 +170,7 @@ function main(_a) {
     check('declaration')
     check('incremental')
     check('tsBuildInfoFile', 'ts_build_info_file')
+    check('isolatedDeclarations', 'isolated_declarations')
     check_preserve_jsx()
     if (failures.length > 0) {
         console.error(

diff --git a/ts/private/ts_validate_options.bzl b/ts/private/ts_validate_options.bzl
@@ -37,6 +37,7 @@ def _validate_action(ctx, tsconfig_inputs):
         source_map = ctx.attr.source_map,
         incremental = ctx.attr.incremental,
         ts_build_info_file = ctx.attr.ts_build_info_file,
+        isolated_declarations = ctx.attr.isolated_declarations,
     )
     arguments.add_all([
         to_output_relative_path(tsconfig),