-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support isolated declarations #636
base: main
Are you sure you want to change the base?
support isolated declarations #636
Conversation
0f98c23
to
a233da6
Compare
a233da6
to
476d498
Compare
62802db
to
476d498
Compare
63e1a43
to
e13986d
Compare
e13986d
to
a3cb0ca
Compare
Rebased on the TS upgrade, so this example should be functional now. I'd still like to verify all the actions have expected inputs and outputs, and maybe add an analysis test showing that. |
Perhaps out of scope of this PR, but it would be interesting to consider an API similar to https://docs.aspect.build/rulesets/aspect_rules_ts/docs/rules#transpiler to allow specifying a non-tsc decleration emit tool (such as swc) |
TypeScript doesn't ship a release yet that calls the new |
Merged a PR on rules_swc to mirror the newest release that has the declaration emit feature, I'll give it a try... |
Changes are visible to end-users: yes
Test plan
isolated_declarations=True
tots_project
.bazel build --build_tag_filters=typing --output_groups=types,typecheck <target>